Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6134 +/- ##
============================================
- Coverage 91.01% 91.00% -0.01%
Complexity 5702 5702
============================================
Files 630 630
Lines 16710 16710
Branches 1656 1656
============================================
- Hits 15208 15207 -1
Misses 1047 1047
- Partials 455 456 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
See my comment for explanation.
Looking closer at this, where does this package access version.properties? If source code needs to access the artifact version, it uses the generated OtelVersion.VERSION constant, as shown here: https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/common/src/main/java/io/opentelemetry/sdk/resources/Resource.java#L60
Not sure what this change aimed to accomplish.
👍 I think it would be nice to have this fix for Instrumentation 2.0.0 |
Fixes open-telemetry/opentelemetry-java-instrumentation#10184
Probably need to publish a patch release for this. cc @open-telemetry/java-approvers