Memory mode: Adding support for synchronous instruments - explicit histogram#6153
Merged
jack-berg merged 32 commits intoopen-telemetry:mainfrom Jan 25, 2024
Conversation
…moryMode.java Co-authored-by: jack-berg <[email protected]>
…lder.java Co-authored-by: jack-berg <[email protected]>
…t1' into memory-mode-sync-instruments-part1
…t: Exponential Histogram
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6153 +/- ##
============================================
- Coverage 91.03% 90.94% -0.10%
- Complexity 5648 5670 +22
============================================
Files 618 620 +2
Lines 16438 16535 +97
Branches 1663 1682 +19
============================================
+ Hits 14965 15037 +72
- Misses 1011 1020 +9
- Partials 462 478 +16 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 15, 2024
Added ProfileBenchmark.
Added ProfileBenchmark.
…nc-instruments-explicit-histogram
jack-berg
approved these changes
Jan 25, 2024
Member
jack-berg
left a comment
There was a problem hiding this comment.
Just a couple of minor comments but looks good. Also, can you rebase and mark ready for review?
…struments-explicit-histogram
Contributor
Author
|
@jack-berg I fixed all comments and rebased it from the |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic
This is one of many PRs that implement #5105. See the complete plan here.
Specifically, this PR adds the implementation of
MemoryModefor the synchronous instrument: explicit histogram.What was done here?
This PR, relative to Exponential Histogram PR, is rather trivial. It contains:
MutableHistogramPointDataand when REUSABLE_DATA is set, it simply re-uses that reusable point to store the aggregated result and returns it.HistogramPointDataImmutableHistogramPointDatainto a shared class, to be used also at the mutable version.It is based on #6136; hence, once it is merged, I'll merge it from the main branch to show its true content.
I will convert it from draft to PR once the previous PR is merged.