Stop including old artifacts in bom#6157
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Jan 18, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6157 +/- ##
=========================================
Coverage 91.03% 91.03%
Complexity 5648 5648
=========================================
Files 619 619
Lines 16443 16443
Branches 1663 1663
=========================================
Hits 14969 14969
Misses 1010 1010
Partials 464 464 ☔ View full report in Codecov by Sentry. |
trask
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See conversation here.
TL:DR: including old artifacts in the bom isn't as useful as we think, since these artifacts can depend on internal APIs which prevent compatibility with current artifacts.
I think its better if we adjust this policy and stop including old artifact coordinates in the bom.