Fault in SdkSpan.events#6244
Merged
jkwatson merged 4 commits intoopen-telemetry:mainfrom Feb 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6244 +/- ##
============================================
- Coverage 91.01% 91.01% -0.01%
- Complexity 5685 5686 +1
============================================
Files 621 621
Lines 16642 16643 +1
Branches 1703 1704 +1
============================================
Hits 15147 15147
Misses 1005 1005
- Partials 490 491 +1 ☔ View full report in Codecov by Sentry. |
breedx-splk
approved these changes
Feb 22, 2024
Contributor
breedx-splk
left a comment
There was a problem hiding this comment.
Seems like a reasonable micro-optimization to me. Thanks!
jkwatson
reviewed
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most spans don't have events [citation needed]. So, fault it in like
attributesandlinksrather than waste time/GC thrash allocating the storage for them.