Rename EventEmitter and related classes to EventLogger#6316
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Mar 26, 2024
Merged
Rename EventEmitter and related classes to EventLogger#6316jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6316 +/- ##
============================================
+ Coverage 91.04% 91.05% +0.01%
- Complexity 5726 5728 +2
============================================
Files 625 625
Lines 16744 16744
Branches 1713 1713
============================================
+ Hits 15244 15247 +3
+ Misses 1006 1003 -3
Partials 494 494 ☔ View full report in Codecov by Sentry. |
breedx-splk
approved these changes
Mar 25, 2024
Contributor
breedx-splk
left a comment
There was a problem hiding this comment.
Big thanks for running with this, I didn't realize you were going to pick this up. ❤️ We're on our way!
| instrumentationScopeName -> | ||
| EventLoggerProvider.noop().eventLoggerBuilder(instrumentationScopeName))) | ||
| .isInstanceOf(IllegalStateException.class) | ||
| .hasMessageContaining("GlobalEventLoggerProvider.set has already been called") |
Member
Author
I've already made all these changes on local branches at one point or another 😛. Just a matter of breaking stuff out into manageable / self contained PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6290.
Part of the goal of bundling several breaking changes into a single release to reduce churn.
cc @breedx-splk