Skip to content

[ticket/17437] Prosilver v2 design for Triton (4.0)#6752

Draft
danieltj27 wants to merge 4 commits intophpbb:masterfrom
danieltj27:ticket/17437
Draft

[ticket/17437] Prosilver v2 design for Triton (4.0)#6752
danieltj27 wants to merge 4 commits intophpbb:masterfrom
danieltj27:ticket/17437

Conversation

@danieltj27
Copy link
Copy Markdown
Member

The prosilver v2 redesign that focuses on updating the current style codebase with a modern design and cleaner HTML and CSS structure allowing style authors to more easily create custom styles whilst also giving phpBB 4.0 a fresh look for the future. This is very much a work in progress!

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

PHPBB-17437

@danieltj27 danieltj27 changed the title [ticket/17437] Begin changes on the prosilver v2 redesign [ticket/17437] Prosilver v2 design for Triton (4.0) Nov 22, 2024
},
"extra": {
"display-name": "prosilver",
"display-name": "prosilver v2",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. It's off to a good start so far 🤣

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically ready for merging 😂

@danieltj27
Copy link
Copy Markdown
Member Author

I'm going to make a big decision right now and say that this new version of prosilver will not include any preprocessors like Sass or similar. There are a couple of reasons for this:

  1. I don't want to pick a preprocessor because whilst it would be very handy to use one, picking one means deciding on something and it's easier in my opinion to decide nothing than picking something someone might not want to use for whatever reason.
  2. The most important reason is it would mean style authors, but more importantly forum admins would have to reverse engineer the CSS that is processed (and likely minified) to make simple style changes. I think it's best to avoid future headaches by making the CSS as simple as possible.

Having said all of that, it doesn't mean we can't or shouldn't use new CSS features like variables and so on. But keeping the stylesheets plain and simple to work with is important.

I've also checked out @marc1706 branch feature/prosilver_25 and like the start he's made. I'm going to try and work that initially stuff into this if I can.

@danieltj27
Copy link
Copy Markdown
Member Author

Undone all changes to the base prosilver style and created a new prosilver2 style as per this comment.

@meis2m
Copy link
Copy Markdown

meis2m commented Nov 22, 2024

i love this idea... i can help you too if you want.

@vinny
Copy link
Copy Markdown
Member

vinny commented Nov 22, 2024

I'm going to make a big decision right now and say that this new version of prosilver will not include any preprocessors like Sass or similar. There are a couple of reasons for this:

  1. I don't want to pick a preprocessor because whilst it would be very handy to use one, picking one means deciding on something and it's easier in my opinion to decide nothing than picking something someone might not want to use for whatever reason.
  2. The most important reason is it would mean style authors, but more importantly forum admins would have to reverse engineer the CSS that is processed (and likely minified) to make simple style changes. I think it's best to avoid future headaches by making the CSS as simple as possible.

Having said all of that, it doesn't mean we can't or shouldn't use new CSS features like variables and so on. But keeping the stylesheets plain and simple to work with is important.

I've also checked out @marc1706 branch and like the start he's made. I'm going to try and work that initially stuff into this if I can.feature/prosilver_25

I agree with you. Sass would be complicated for administrators without knowledge, just check the style forum, most of them can't change the logo, banner, the color of a link with simple CSS.

@meis2m
Copy link
Copy Markdown

meis2m commented Nov 23, 2024

i have some suggestions:
1- we need ACP style settings , in style settings admin can change logo, color, favicon ... and access to html and css files directly.
2- in settings admin can choose grid option or forumlist option.
3- have a dark mode - users can select dark mode manually. some where in footer or header.
4- add widget system and have a site builder , admin can customise style something like elementor in wordpress or site builder in vbulletin6.

@DavidIQ
Copy link
Copy Markdown
Member

DavidIQ commented Nov 23, 2024

i have some suggestions: 1- we need ACP style settings , in style settings admin can change logo, color, favicon ... and access to html and css files directly. 2- in settings admin can choose grid option or forumlist option. 3- have a dark mode - users can select dark mode manually. some where in footer or header. 4- add widget system and have a site builder , admin can customise style something like elementor in wordpress or site builder in vbulletin6.

None of that is going to be done here. Only the style is being refreshed, as the title and description suggest. Feel free to create tickets for each so they can be considered for a future version.

@danieltj27
Copy link
Copy Markdown
Member Author

@meis2m just as @DavidIQ has said this is purely focusing on the style itself.

I do agree that having style settings, particularly a unified way of editing styles like logos and so on would be great, but that is out of scope of this work and would require lots of back-end work to get the settings ready to be used by said style. Good idea and I'd like to see that sort of thing added too, but not right now 😏

@vinny
Copy link
Copy Markdown
Member

vinny commented Nov 23, 2024

i have some suggestions: 1- we need ACP style settings , in style settings admin can change logo, color, favicon ... and access to html and css files directly. 2- in settings admin can choose grid option or forumlist option. 3- have a dark mode - users can select dark mode manually. some where in footer or header. 4- add widget system and have a site builder , admin can customise style something like elementor in wordpress or site builder in vbulletin6.

All of this can be done with an extension, if you look in the CDB, there is already an extension for each suggestion.

@Voxybuns
Copy link
Copy Markdown

hello,

i was wondering if this project of a new default theme for phpBB was still on the rails, as it's a little difficult to find up-to-date information given how it's spread across github, the area51 forums, and the area51 tracker.

i'd like to help contribute to a v2 of prosilver so it can keep up with modern html/css authoring and design sensibilities, as i'm quite nostalgic of the forums era, and i feel that making phpBB look and feel like a properly modern piece of software could make it a more attractive option in a sea of insular discord servers that are nigh-impossible to properly search information through! :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants