[WIP] Issue #631 — respecting CMake's CMAKE_INSTALL_PREFIX for installation#659
Draft
leftibot wants to merge 1 commit intoChaiScript:developfrom
Draft
Conversation
…rs for install paths The CMakeLists.txt used CMAKE_INSTALL_LIBDIR in install destinations without including the GNUInstallDirs module, leaving the variable empty. This caused libraries to install to absolute paths like /chaiscript instead of lib/chaiscript, and the pkg-config file to install to /pkgconfig instead of lib/pkgconfig. The chaiscript.pc.in template also hardcoded "lib" and "include" instead of using the CMake variables. Added include(GNUInstallDirs) and updated the .pc.in template to use @CMAKE_INSTALL_LIBDIR@ and @CMAKE_INSTALL_INCLUDEDIR@. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated attempt by @leftibot. Opening as draft — verification failed.
Reason: no test files were detected in the diff
What changed
Files
Will close #631 once finalized.
Triggered by @lefticus.