Fix #378: double Parsing Slight Innaccuracies#669
Open
leftibot wants to merge 1 commit intoChaiScript:developfrom
Open
Fix #378: double Parsing Slight Innaccuracies#669leftibot wants to merge 1 commit intoChaiScript:developfrom
leftibot wants to merge 1 commit intoChaiScript:developfrom
Conversation
…_chars The custom parse_num floating-point implementation produced slightly different results from the C++ compiler's own literal parsing (e.g. 1.1e-4 was off by a few ULPs). Replace it with std::from_chars which is locale-independent and matches compiler precision exactly. Also migrate integer parsing in buildInt from std::stoll/stoull to std::from_chars, fix the JSON number parser to pass the full numeric string to from_chars instead of splitting mantissa/exponent and using std::pow, and update parse_string to use from_chars for arithmetic types. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #378
Triggered by @lefticus.