Skip to content

Fix #666: TSAN builds don't actually use threads#670

Merged
lefticus merged 2 commits intoChaiScript:developfrom
leftibot:fix/issue-666-tsan-builds-don-t-actually-use-threads
Apr 12, 2026
Merged

Fix #666: TSAN builds don't actually use threads#670
lefticus merged 2 commits intoChaiScript:developfrom
leftibot:fix/issue-666-tsan-builds-don-t-actually-use-threads

Conversation

@leftibot
Copy link
Copy Markdown
Contributor

Automated fix by @leftibot.

What changed

Fix #666: TSAN builds don't actually use threads
TSAN builds did not explicitly enable MULTITHREAD_SUPPORT_ENABLED, so they
relied on the CMake default. This adds -DMULTITHREAD_SUPPORT_ENABLED=ON to
both TSAN jobs and expands the CI matrix to cover threading on/off with
Debug/Release for Linux, macOS, and Windows MSVC. Also excludes async-dependent
.chai tests from non-threaded builds and adds a Threading_Config_Test to verify
the threading configuration is correct in both modes.
Co-Authored-By: Claude Opus 4.6 (1M context) [email protected]

Files

 .github/workflows/ci.yml            | 19 +++++++++++--------
 CMakeLists.txt                      | 13 +++++++++++++
 unittests/threading_config_test.cpp | 26 ++++++++++++++++++++++++++
 3 files changed, 50 insertions(+), 8 deletions(-)

Closes #666

Triggered by @lefticus.

TSAN builds did not explicitly enable MULTITHREAD_SUPPORT_ENABLED, so they
relied on the CMake default. This adds -DMULTITHREAD_SUPPORT_ENABLED=ON to
both TSAN jobs and expands the CI matrix to cover threading on/off with
Debug/Release for Linux, macOS, and Windows MSVC. Also excludes async-dependent
.chai tests from non-threaded builds and adds a Threading_Config_Test to verify
the threading configuration is correct in both modes.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@lefticus
Copy link
Copy Markdown
Member

@leftibot Use ninja instead of makefiles for all unix targets for the cmake generator

Requested by @lefticus in PR ChaiScript#670 review.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@leftibot
Copy link
Copy Markdown
Contributor Author

Addressed review feedback from @lefticus. New commits:

861805d9 Address review: use Ninja generator for all unix CI targets

@lefticus lefticus merged commit 4804fb6 into ChaiScript:develop Apr 12, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSAN builds don't actually use threads

2 participants