Skip to content

Update User-Agent with the most recent version#2548

Open
myprivateproxy wants to merge 1 commit intoRocketMap:developfrom
myprivateproxy:fix-user-agent
Open

Update User-Agent with the most recent version#2548
myprivateproxy wants to merge 1 commit intoRocketMap:developfrom
myprivateproxy:fix-user-agent

Conversation

@myprivateproxy
Copy link
Copy Markdown

Description

User-Agent header is too old and it should be updated

Motivation and Context

This fix possibly helps to prevent detecting a suspicious traffic and a resulting ban of proxies

How Has This Been Tested?

New header is from mitmproxy and a real PokémonGo on iOS

Screenshots (if appropriate):

poke_headers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FrostTheFox
Copy link
Copy Markdown
Member

Unlikely to be a major issue as this UA is CFNetwork and Darwin versions (which are generally speaking relative to iOS version, and thus not really an issue, as these current UAs were pulled from my own iPhone devices a couple iOS versions ago).

Still good to update though.

@myprivateproxy
Copy link
Copy Markdown
Author

The answer is 'a couple iOS versions ago'. Most users update iOS within a week. Nevermind.

@FrostTheFox
Copy link
Copy Markdown
Member

FrostTheFox commented Mar 21, 2018

Okay, and? Niantic nor PTC are going to ban someone because they are using older iOS versions. We're talking within the major iOS version (so something like 11.1) here. I'm not speaking of iOS 8 here.\

I don't disagree with the change, otherwise I would have closed the PR. I don't think it's a MAJOR MERGE ASAP change though.

Copy link
Copy Markdown
Member

@FrostTheFox FrostTheFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked these headers under latest iOS, iPhone X.

@sebastienvercammen sebastienvercammen added this to the 4.1.1 milestone Mar 22, 2018
Copy link
Copy Markdown
Contributor

@fosJoddie fosJoddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes on it's own works fine (proxies are still banned).

However it is worth to point out that these changes ONLY changes the user agent of the proxy checks.

The user agent used for actual requests are defined in the pgoapi.

Copy link
Copy Markdown
Member

@sebastienvercammen sebastienvercammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR also requires a pgoapi User-Agent update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants