Preserve path_column in structure_pdfs results for cache-hit jobs#1272
Open
Reichenbachian wants to merge 2 commits intomainfrom
Open
Preserve path_column in structure_pdfs results for cache-hit jobs#1272Reichenbachian wants to merge 2 commits intomainfrom
Reichenbachian wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Prompt
pull the sdk and make a pr fixing this
Surprises and Discoveries
structure_pdfswas overwritingpath_columnfrom a localjob_to_pdf_pathmap keyed by submitted job IDs.pdf_pathfromentity.properties.Changes Made
structure_pdfsrow assembly to readpath_columndirectly fromentity.propertiesinstead of remapping viajob_to_pdf_path.pdf_pathstable for cache-hit entities and avoids dropping values in downstream workflow tables.Tests
uv run python -m py_compile src/structify/resources/polars.py.