Core/Unit: Normalize charmed units speed and also drop unneeded combat check#31753
Draft
imstuckbro wants to merge 2 commits intoTrinityCore:3.3.5from
Draft
Core/Unit: Normalize charmed units speed and also drop unneeded combat check#31753imstuckbro wants to merge 2 commits intoTrinityCore:3.3.5from
imstuckbro wants to merge 2 commits intoTrinityCore:3.3.5from
Conversation
Contributor
|
I am against meddling with speeds like this. Follow movement for controlled units needs some extra love within the follow motionmaster. Speed values should not change on a creature level - it needs dynamic calculations on a spline level |
Author
|
is this any better :D ? |
Contributor
|
not really, as Ovahlord mentioned, the speed should be calculated within splines calculation. |
Author
|
can you point me where exactly that happens ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
Closes #26754
Updates #30169
Tests performed:
Does it build, tested in-game, etc.
Known issues and TODO list: (add/remove lines as needed)