Scripts/ExilesReach: Update and add conversation for quests 58208/59928#31759
Open
Saburo-Arasaka wants to merge 8 commits intoTrinityCore:masterfrom
Open
Scripts/ExilesReach: Update and add conversation for quests 58208/59928#31759Saburo-Arasaka wants to merge 8 commits intoTrinityCore:masterfrom
Saburo-Arasaka wants to merge 8 commits intoTrinityCore:masterfrom
Conversation
Add conversation for quests 58208/59928 Add Garrick
Add scripts for quests 58208/59928
mdX7
reviewed
Mar 29, 2026
Member
mdX7
left a comment
There was a problem hiding this comment.
i'd prefer to use templates for npc_first_mate_brace_for_impact_private and not use so many member variables.
template<uint32 Path, uint32 NpcID, uint32 Conversation, uint32 Actor0, uint32 Actor1>
|
usually a database sql file should actually have .sql extension format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conversation for quests 58208/59928
Add Garrick
Reworked npc scripts for quests 58208/59928