Skip to content

Core/Creatures: Added fields for static flags to creature class#31780

Open
Thelsen wants to merge 5 commits intoTrinityCore:3.3.5from
Thelsen:static_flags
Open

Core/Creatures: Added fields for static flags to creature class#31780
Thelsen wants to merge 5 commits intoTrinityCore:3.3.5from
Thelsen:static_flags

Conversation

@Thelsen
Copy link
Copy Markdown
Contributor

@Thelsen Thelsen commented Apr 7, 2026

Changes proposed:

  • Initial port of creature static flags fields

Tests performed:

(Does it build, tested in-game, etc.)

Build only

@Thelsen Thelsen marked this pull request as draft April 7, 2026 19:23
@Thelsen Thelsen marked this pull request as ready for review April 7, 2026 20:23
@Thelsen
Copy link
Copy Markdown
Contributor Author

Thelsen commented Apr 19, 2026

I think that the wrong way, and we should first import creature_template_difficulty to avoid to move again creature_static_flags fields. I'm working on it, so for the moment I move this PR to draft.

@Thelsen Thelsen marked this pull request as draft April 19, 2026 14:27
@Shauren
Copy link
Copy Markdown
Member

Shauren commented Apr 19, 2026

What? No, 3.3.5 will never get creature_template_difficulty. creature_template is the final destination for static flags

@Thelsen Thelsen marked this pull request as ready for review April 19, 2026 14:50
@Thelsen
Copy link
Copy Markdown
Contributor Author

Thelsen commented Apr 19, 2026

What? No, 3.3.5 will never get creature_template_difficulty. creature_template is the final destination for static flags

My bad. With this discussion (#25626) I was thinking that what applied to retail with these static fields was true in the early versions of the game.

So I figured it would be easier to do things in order. Especially since I was looking at the differences in how Difficulty IDs are handled between the retail and WrW versions for the latest commit, with the individual override of the static flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants