Scripts/WanderingIsle: Implement quest 29664 (The Challenger's Flames)#31785
Open
aquadeus wants to merge 3 commits intoTrinityCore:masterfrom
Open
Scripts/WanderingIsle: Implement quest 29664 (The Challenger's Flames)#31785aquadeus wants to merge 3 commits intoTrinityCore:masterfrom
aquadeus wants to merge 3 commits intoTrinityCore:masterfrom
Conversation
mdX7
reviewed
Apr 11, 2026
Naddley
requested changes
Apr 12, 2026
Comment on lines
+28
to
+30
| DELETE FROM `quest_objectives_completion_effect` WHERE `ObjectiveID`=255751; | ||
| INSERT INTO `quest_objectives_completion_effect` (`ObjectiveID`, `GameEventID`, `SpellID`, `ConversationID`, `UpdatePhaseShift`, `UpdateZoneAuras`) VALUES | ||
| (255751, NULL, 108695, NULL, 0, 1); |
Member
There was a problem hiding this comment.
This should be in a spell_area to remove/apply it correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed:
Tested in-game