fix return, break and continue inside try in async functions (#1706)#1707
Open
RealColdFry wants to merge 5 commits intoTypeScriptToLua:masterfrom
Open
fix return, break and continue inside try in async functions (#1706)#1707RealColdFry wants to merge 5 commits intoTypeScriptToLua:masterfrom
RealColdFry wants to merge 5 commits intoTypeScriptToLua:masterfrom
Conversation
Perryvw
reviewed
Apr 13, 2026
| ), | ||
| ]; | ||
| if (results.length > 0) { | ||
| stmts.push(lua.createAssignmentStatement(lua.createIdentifier("____returnValue"), results[0], statement)); |
Member
There was a problem hiding this comment.
Guess this breaks for multi-return, any easy wayt to serve those cases? (otherwise I'm okay with merging the easier change first)
Contributor
Author
There was a problem hiding this comment.
multi-return actuallyy works here 20b205dc because the multi-return values are wrapped into a single table before storage so results[0] captures everything. But it was somewhat confusing and relied on implicit assumptions so I split out transformReturnExpressionForTryCatch which returns a single lua.Expression instead of indexing into an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1706