Use path_for helper to include url_options in breadcrumb links#7807
Open
drcapulet wants to merge 1 commit intoactiveadmin:masterfrom
Open
Use path_for helper to include url_options in breadcrumb links#7807drcapulet wants to merge 1 commit intoactiveadmin:masterfrom
drcapulet wants to merge 1 commit intoactiveadmin:masterfrom
Conversation
Member
|
What's the real objective/purpose here? I haven't had to do anything really with breadcrumb links so don't see what the need is here for. |
Author
|
@javierjulio We need to propagate a query parameter to all links - something you can do by defining |
13b2e39 to
24fb389
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7807 +/- ##
==========================================
- Coverage 98.92% 98.90% -0.03%
==========================================
Files 197 197
Lines 4950 4950
==========================================
- Hits 4897 4896 -1
- Misses 53 54 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't exactly the same behavior you'd get with a named path helper since it doesn't require the
paramskey, but it is very close.