GH-3461: Avoid unnecessary debug logging overhead in record write hot path#3462
Merged
Fokko merged 1 commit intoapache:masterfrom Apr 21, 2026
Merged
Conversation
wgtmac
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
InternalParquetRecordWriter.checkBlockSizeReachedruns in a hot path, and we observed unnecessary overhead from debug log argument handling when debug logging is disabled. At high throughput (millions of records), this avoidable work can accumulate and impact write efficiency.What changes are included in this PR?
This PR adds
LOG.isDebugEnabled()guards around debug log statements inInternalParquetRecordWriter.checkBlockSizeReached.Are these changes tested?
No new tests were added because the change is non-functional and limited to logging guards. Existing writer tests continue to cover the affected code paths functionally, and behavior is expected to remain unchanged.
Are there any user-facing changes?
There are no user-facing behavior changes. The expected impact is reduced internal overhead in high-volume write scenarios when debug logging is not enabled.
Closes #3461