Skip to content

feat: Git commit message that skips deployment#11849

Open
HarshMN2345 wants to merge 3 commits into1.9.xfrom
feat-skip-deployment-commit-message
Open

feat: Git commit message that skips deployment#11849
HarshMN2345 wants to merge 3 commits into1.9.xfrom
feat-skip-deployment-commit-message

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 10, 2026

Greptile Summary

This PR adds a shouldSkipGitDeployment() helper that checks for [skip deploy] or [skip deployment] in the commit message (case-insensitive), and short-circuits createGitDeployments before any build is queued. The skip check is now correctly placed after $logBase is set to the real repository ID, so the span key issue from the previous review thread is addressed. However, the six lines immediately following the skip check (lines 79–87) are a verbatim copy of the block that already ran at lines 64–72; they should be removed.

Confidence Score: 5/5

Safe to merge after removing the duplicate variable/span block; the core skip logic and regex are correct.

The only finding is a P2 code-duplication issue (redundant variable assignments and span calls) that does not affect deployment behavior or data correctness. All prior concerns about the repo.unknown span key are resolved.

src/Appwrite/Platform/Modules/VCS/Http/GitHub/Deployment.php — lines 79–87 should be deleted.

Important Files Changed

Filename Overview
src/Appwrite/Platform/Modules/VCS/Http/GitHub/Deployment.php Adds shouldSkipGitDeployment() method and skip-check logic using [skip deploy]/[skip deployment] in commit message; introduces a duplicate variable-assignment and span-logging block immediately after the skip check that is redundant.

Reviews (3): Last reviewed commit: "Merge branch '1.9.x' into feat-skip-depl..." | Re-trigger Greptile

Comment thread src/Appwrite/Platform/Modules/VCS/Http/GitHub/Deployment.php
HarshMN2345 and others added 2 commits April 10, 2026 12:56
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🔄 PHP-Retry Summary

Flaky tests detected across commits:

Commit e444197 - 8 flaky tests
Test Retries Total Time Details
UsageTest::testFunctionsStats 1 10.26s Logs
UsageTest::testPrepareSitesStats 1 7ms Logs
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage 1 5ms Logs
LegacyConsoleClientTest::testListDocumentsWithCache 1 462ms Logs
LegacyConsoleClientTest::testListDocumentsCachePurgedByUpdate 1 1.76s Logs
LegacyCustomClientTest::testCreateIndexes 1 242.82s Logs
LegacyCustomServerTest::testNotContains 1 240.45s Logs
LegacyTransactionsCustomServerTest::testBulkUpdateMatchingUpdatedDocuments 1 240.22s Logs

@HarshMN2345
Copy link
Copy Markdown
Member Author

@greptile

@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,691
  • Requests with 200 status code: 304,348
  • P99 latency: 0.109456549

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,691 1,315
200 304,348 236,656
P99 0.109456549 0.154440055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant