feat: Git commit message that skips deployment#11849
feat: Git commit message that skips deployment#11849HarshMN2345 wants to merge 3 commits into1.9.xfrom
Conversation
Greptile SummaryThis PR adds a Confidence Score: 5/5Safe to merge after removing the duplicate variable/span block; the core skip logic and regex are correct. The only finding is a P2 code-duplication issue (redundant variable assignments and span calls) that does not affect deployment behavior or data correctness. All prior concerns about the repo.unknown span key are resolved. src/Appwrite/Platform/Modules/VCS/Http/GitHub/Deployment.php — lines 79–87 should be deleted. Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch '1.9.x' into feat-skip-depl..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
🔄 PHP-Retry SummaryFlaky tests detected across commits: Commit
|
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.26s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
LegacyConsoleClientTest::testListDocumentsWithCache |
1 | 462ms | Logs |
LegacyConsoleClientTest::testListDocumentsCachePurgedByUpdate |
1 | 1.76s | Logs |
LegacyCustomClientTest::testCreateIndexes |
1 | 242.82s | Logs |
LegacyCustomServerTest::testNotContains |
1 | 240.45s | Logs |
LegacyTransactionsCustomServerTest::testBulkUpdateMatchingUpdatedDocuments |
1 | 240.22s | Logs |
|
@greptile |
✨ Benchmark results
⚡ Benchmark Comparison
|
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist