(fix): reset route to avoid clobbering otel#11885
Conversation
Greptile SummaryStores the active Confidence Score: 5/5Safe to merge; the fix is minimal and correct, with only a minor P2 observation about the null-original edge case. Single-file, targeted fix. The try/finally pattern correctly covers both the happy path and exception path. The only open question (null-route guard) is a minor style concern that does not affect the primary bug being fixed. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "(chore): rename" | Re-trigger Greptile |
🔄 PHP-Retry SummaryFlaky tests detected across commits: Commit
|
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.24s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
LegacyConsoleClientTest::testListDocumentsWithCache |
1 | 274ms | Logs |
LegacyConsoleClientTest::testListDocumentsCacheBustedByAttributeChange |
1 | 1.14s | Logs |
LegacyConsoleClientTest::testListDocumentsCachePurgedByUpdate |
1 | 715ms | Logs |
LegacyCustomClientTest::testCreateIndexes |
1 | 246.06s | Logs |
LegacyCustomServerTest::testCreateIndexes |
1 | 241.06s | Logs |
LegacyTransactionsCustomClientTest::testIncrementDecrementEndpointsWithTransaction |
1 | 240.56s | Logs |
✨ Benchmark results
⚡ Benchmark Comparison
|
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist