Add publication references to genbank parser#593
Add publication references to genbank parser#593mkleen wants to merge 4 commits intobiojava:masterfrom mkleen:master
Conversation
josemduarte
left a comment
There was a problem hiding this comment.
The test org.biojava.nbio.core.sequence.io.GenbankCookbookTest.testProcess is failing, could you have a look? Thanks
| /note="Norrie disease (pseudoglioma)" | ||
| /db_xref="GeneID:4693" | ||
| /db_xref=" :4693" | ||
| /db_xref="HGNC:7678" |
There was a problem hiding this comment.
Hi,
not sure why you are removing the text GeneID here? this is content that is also in the original file:
https://www.ncbi.nlm.nih.gov/nuccore/223972707?report=genbank
|
I will fix the testcase, i have also a few more commits. |
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
There was a problem hiding this comment.
Could you document this Class with javadoc?
| @@ -0,0 +1,60 @@ | |||
| package org.biojava.nbio.core.sequence.features; | |||
|
|
|||
There was a problem hiding this comment.
Could you document this Class with javadoc?
| /** | ||
| * Test of process method, of class GenbankReader. | ||
| */ | ||
| @Ignore |
There was a problem hiding this comment.
Why do we ignore this test now? I think it was failing with unknown reason.
|
Dear @mkleen, what is the status of this PR? Could you also provide a bit more description of what is added (new features) in this PR? |
|
This has been open for more than 6 months and it already has conflicts with the master branch. I would suggest closing it with the possibility of reopening it in the future. |
|
Yes, let's close. There was no response to the comments for a long time. |
No description provided.