Get nmconnection name by interface-name first#409
Merged
Dany9966 merged 1 commit intocloudbase:masterfrom Apr 16, 2026
Merged
Conversation
Dany9966
requested changes
Apr 14, 2026
39ad1c9 to
fb3a67e
Compare
Dany9966
requested changes
Apr 15, 2026
| "mac_address": None, | ||
| "ip_addresses": ["192.168.1.40"] | ||
| }, | ||
| "System ethx": { |
Contributor
There was a problem hiding this comment.
We shouldn't support any spaces as the interface name, as this value will go straight into the udev rules. Please fix this in the code.
fb3a67e to
ac7902e
Compare
Dany9966
requested changes
Apr 15, 2026
| if not name: | ||
| name = re.match(r"^.*/(.*)\.nmconnection$", | ||
| nmconn_file).groups()[0] | ||
| if not name or " " in name: |
Contributor
There was a problem hiding this comment.
This isn't exactly what I meant :)
I meant something in the lines of:
name.replace(' ', '_')ac7902e to
22bf731
Compare
22bf731 to
232fe9e
Compare
Dany9966
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.