Conversation
|
|
||
| # a shortcut to avoid long lines | ||
| dir="$abs_top_builddir/src" | ||
| gprintf="$abs_top_builddir/src/printf" |
There was a problem hiding this comment.
did you not use command -v because printf is a builtin generally?
I suppose $gprintf is built as the tests start with print_ver_ printf
There was a problem hiding this comment.
did you not use command -v because printf is a builtin generally?
Yes. (I'm not familiar with test suite init)
There was a problem hiding this comment.
$(print_ver_ any_buitin_cmd)env printf?
There was a problem hiding this comment.
yes print_ver_() uses env(1) to avoid builtins
|
|
||
| # Before 2004-04-21, install would infloop, in the 'while (wait...' loop: | ||
| exec ginstall -s "$abs_top_builddir/src/ginstall$EXEEXT" . | ||
| exec ginstall -s "$(command -v ginstall)" . |
There was a problem hiding this comment.
Yes I suppose it doesn't matter what we install here.
It will fail if ginstall is a shebang script, but we don't check that.
I.e. there is no need to change this one apart from minimizing use of $abs_top_builddir
There was a problem hiding this comment.
I think we could skip building GNU ginstall via GitHub cache provided getlimits.
There was a problem hiding this comment.
It will fail if ginstall is a shebang script,
uutils use actual binary now.
| nproc=$abs_top_builddir/src/nproc$EXEEXT | ||
| nproc="$(command -v nproc)" | ||
| cp --parents $(ldd $nproc | grep -o '/[^ ]*') $ROOT || | ||
| skip_ 'Failed to copy nproc libs to chroot' |
There was a problem hiding this comment.
So we'd skip for shebang scripts
| nproc="$(command -v nproc)" | ||
| cp --parents $(ldd $nproc | grep -o '/[^ ]*') $ROOT || | ||
| skip_ 'Failed to copy nproc libs to chroot' | ||
| cp $nproc $ROOT || framework_failure_ |
There was a problem hiding this comment.
But should work for symlinks/hardlinks
pixelb
left a comment
There was a problem hiding this comment.
I can't see any issues with this, though command resolution is subtle.
I might wait until after the impending 9.10 release to merge this one
|
Can we simply swap all of |
|
One caveat is that users might ./configure --enable-no-install-program=dirname |
|
Are |
|
getlimits should always be there yes. ginstall is not treated any differently so might not be present |
tests/install/basic-1.shis related withstrip. So we should want to keep those abs_...