Open
Conversation
timor
reviewed
May 4, 2019
timor
reviewed
May 4, 2019
Member
|
I’m not sure this suggestion works.
… On May 4, 2019, at 7:12 AM, kusumotonorio ***@***.***> wrote:
@kusumotonorio commented on this pull request.
In basis/ui/backend/gtk/gtk.factor:
> - [ event-modifiers ] [ keyval>> key-sym ] [
- type>> GDK_KEY_PRESS = [ <key-down> ] [ <key-up> ] if
- ] tri ;
-
-: on-key-press/release ( win event user-data -- ? )
- drop swap [ key-event>gesture ] [ window ] bi* propagate-key-gesture t ;
-
+:: key-event>gesture ( event -- key-gesture )
+ event event-modifiers
+ event keyval>> code>sym drop
+ dup integer? not [
+ drop event keyval>> key-sym
+ ] [
+ gdk_keyval_to_unicode 1string f
+ ] if
+ event type>> GDK_KEY_PRESS = [ <key-down> ] [ <key-up> ] if ;
That's good.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
Thank you, John. It certainly seems so. |
Member
|
We should review this and merge if it's working! @erg |
Member
|
@kusumotonorio I tried this and it returns Could you please rebase this onto master and see if you can fix it? I will merge sooner next time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote the cord which fixed key-down/up event issues on gtk backend Factor. It improves:
on key-down/up events.