fix(litellm): Avoid double span exits when streaming#5933
Draft
alexander-alderman-webb wants to merge 8 commits intomasterfrom
Draft
fix(litellm): Avoid double span exits when streaming#5933alexander-alderman-webb wants to merge 8 commits intomasterfrom
alexander-alderman-webb wants to merge 8 commits intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Other
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.64s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14911 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only exit the span on the final invocation of
_success_callbackwhenlitellmstreams a response.The
litellm.success_callbackcallbacks are fired multiple times when streaming a response withlitellm.Avoid an unhandled SDK exception by using
litellmlike a user would in the relevant test.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)