This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=========================================
Coverage 70.90% 70.90%
Complexity 1104 1104
=========================================
Files 24 24
Lines 3420 3420
Branches 525 525
=========================================
Hits 2425 2425
Misses 780 780
Partials 215 215 Continue to review full report at Codecov.
|
olavloite
commented
Dec 16, 2020
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-cloud-spanner-v1</artifactId> | ||
| </dependency> | ||
| <dependency> |
Collaborator
Author
There was a problem hiding this comment.
This is a duplicate of the dependency right above.
thiagotnunes
approved these changes
Dec 16, 2020
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Dec 17, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.18.3](https://www.github.com/googleapis/java-spanner-jdbc/compare/v1.18.2...v1.18.3) (2020-12-16) ### Dependencies * update spanner to 3.1.2 ([#306](https://www.github.com/googleapis/java-spanner-jdbc/issues/306)) ([596e8ed](https://www.github.com/googleapis/java-spanner-jdbc/commit/596e8ed01dc8ffc01c37b233f688d163b8693f85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Temporarily) fixes the dependency problem caused by the addition of
grpc-altsas a runtime dependency ingoogle-cloud-spannerand updates Spanner client library to 3.1.2.Once googleapis/java-spanner#757 has been merged and is available in the shared libraries, or another fix for the problem described in that PR, the TODO's in this PR can be reverted.
Replaces #293