Conversation
|
@jeff5 , please review this PR. |
|
@Stewori , please review this PR. |
|
Yes, I took a look. IIRC we discussed the idea somewhere else earlier. I was concerned to simply bypass this safety measure in Java, at least as long as it's just a warning. Given that they announce to block it more strictly it is probably indeed the most future-proof decision to adjust this as you suggest. To keep for Jython the "business as usual". I am certain, Jeff will find time to look at this before release. It won't be forgotten, I just won't merge it right now without a second opinion. |
|
I tagged this to cover the "not forgetting" part of Stefan's promise. |
|
@Stewori We had a similar conversation about access to private members under The logic here is different. Here, we seem to have a (permanent) option to enable the behaviour. I would not do that in the JARs we offer as Java dependencies, since it should be up to the consuming application. For the standalone JAR, that feels ok. A bit of hunting around shows that the cause is our use of a long superseded JLine version. (I've never had the stomach for the changes necessary to update it.) However, if you don't use JLine, it just happens somewhere else. |
Without this PR fix applied, Jython displays the following warning when using Java 25:
With the fix applied, the warning is suppressed.
To be considered for inclusion in Jython 2.7.5