Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the KNIME Python Scripting Editor frontend (Vue) to use the newer KDS tab bar component in the right pane, aligning the UI with the KDS component library.
Changes:
- Replace the existing right-pane tab bar component with
KdsTabBarand adapt the tab configuration to the new API. - Update component styling for the right pane/tab bar layout.
- Update unit tests and bump
@knime/kds-componentsto0.22.3.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
org.knime.python3.scripting.nodes/js-src/src/components/App.vue |
Swaps the right-pane tab bar implementation to KdsTabBar, updates tab model/options, and adjusts layout styling. |
org.knime.python3.scripting.nodes/js-src/src/components/__tests__/App.test.ts |
Updates stubs and component lookup logic to match KdsTabBar. |
org.knime.python3.scripting.nodes/js-src/package.json |
Updates @knime/kds-components dependency version. |
org.knime.python3.scripting.nodes/js-src/package-lock.json |
Lockfile updates corresponding to the dependency bump (and transitive changes). |
Files not reviewed (1)
- org.knime.python3.scripting.nodes/js-src/package-lock.json: Language not supported
04e2d8e to
4ca02db
Compare
4ca02db to
2c6bc11
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-25849 (Scripting Editor - Replace TabBar with KdsTabBar)