Assume that image in cache if skipBuild defined#3883
Assume that image in cache if skipBuild defined#3883giggsoff wants to merge 1 commit intolinuxkit:masterfrom
Conversation
bbf06fa to
37910f5
Compare
|
This is not quite the issue. It is good that I think the problem is here where it says: // we only will push if one of these is true:
// - we had at least one platform to build
// - we found an image in local cache
// if neither is true, there is nothing to push
if len(platformsToBuild) == 0 && !imageInLocalCache {
fmt.Fprintf(writer, "No new platforms to push, skipping.\n")
return nil
}It looks like |
If skipBuild defined we should try to push the image Signed-off-by: Petr Fedchenkov <[email protected]>
37910f5 to
a3a2198
Compare
|
So we just want to go into |
|
Makes sense. It should be easy enough to test. Did you try? |
Not yet, no enough bandwidth on my PC. Will try and remove draft if it will work |
|
It works, at least I can see |
If skipBuild defined we should try to push the image
Signed-off-by: Petr Fedchenkov [email protected]