Open
Conversation
if starting the builder container fails, return the error message from docker Signed-off-by: Christoph Ostarek <[email protected]>
'-output' is now called '--o' Signed-off-by: Christoph Ostarek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Improving error messages in case of failure
- How I did it
One case: simply fixing the format string
Other case: getting the output into a bytes.Buffer and adding it to the returned Error
- How to verify it
Probably the easiest way is to just review and read the code.
- Description for the changelog
Improving error messages
- A picture of a cute animal (not mandatory but encouraged)