env: move builder getenv out of cobra cmds#4206
Draft
christoph-zededa wants to merge 1 commit intolinuxkit:masterfrom
Draft
env: move builder getenv out of cobra cmds#4206christoph-zededa wants to merge 1 commit intolinuxkit:masterfrom
christoph-zededa wants to merge 1 commit intolinuxkit:masterfrom
Conversation
3c87a33 to
84555e0
Compare
Contributor
Author
|
@rucoder can you have a look at this? You did the original PR. |
6 tasks
as it has been introduced in 666bbfd this makes it possible to profit from this change also when using linuxkit as a library (e.g. lf-edge/eve/bpftrace-compiler) Signed-off-by: Christoph Ostarek <[email protected]>
84555e0 to
073c05f
Compare
europaul
added a commit
to rene/eve
that referenced
this pull request
Apr 16, 2026
to test linuxkit/linuxkit#4206 Signed-off-by: Paul Gaiduk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as it has been introduced in 666bbfd
this makes it possible to profit from this change also when using linuxkit as a library (e.g. lf-edge/eve/bpftrace-compiler)
- What I did
move builder getenv out of cobra cmds
- How I did it
adding one
func init()and changing some other funcs- How to verify it
same as #4205
- Description for the changelog
move builder getenv out of cobra cmds
- A picture of a cute animal (not mandatory but encouraged)
