Skip to content

Migrate contribs client to main client#1075

Open
esoteric-ephemera wants to merge 14 commits intomainfrom
contribs
Open

Migrate contribs client to main client#1075
esoteric-ephemera wants to merge 14 commits intomainfrom
contribs

Conversation

@esoteric-ephemera
Copy link
Copy Markdown
Collaborator

@esoteric-ephemera esoteric-ephemera commented Apr 6, 2026

See MPContribs #1982 for more details about client reorganization.

Pulls mpcontribs-client into mp_api as an optional add-on. Changes include:

  • Reorganize client into modules for easier editing
  • Replace some quasi-deprecated packages in favor of those already in the stack (e.g., ujson in favor of orjson)
  • Align the syntaxes of the main API client and the MPC client (i.e., consistent naming of class kwargs)
  • dynamically constructed pydantic models for returned data types in contribs

@esoteric-ephemera esoteric-ephemera mentioned this pull request Apr 6, 2026
Open
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 53.54142% with 774 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.53%. Comparing base (2b82e62) to head (716d9ef).

Files with missing lines Patch % Lines
mp_api/client/contribs/client.py 37.58% 694 Missing ⚠️
mp_api/client/contribs/_types.py 74.70% 43 Missing ⚠️
mp_api/client/contribs/utils.py 70.68% 17 Missing ⚠️
mp_api/client/contribs/schemas.py 93.75% 9 Missing ⚠️
mp_api/client/contribs/_logger.py 85.71% 6 Missing ⚠️
mp_api/client/contribs/settings.py 91.48% 4 Missing ⚠️
mp_api/client/core/schemas.py 98.57% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1075       +/-   ##
===========================================
- Coverage   86.66%   73.53%   -13.13%     
===========================================
  Files          47       56        +9     
  Lines        2624     4225     +1601     
===========================================
+ Hits         2274     3107      +833     
- Misses        350     1118      +768

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@esoteric-ephemera @codecov-commenter