Fix CodeQL warnings in Python#6230
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom Apr 17, 2026
Merged
Conversation
Instead of calling index() and ignoring ValueError, we can guard the logic with `if VALUE in LIST`.
The warnings say "Except doesn't do anything and has no comment", so we should be able to add comments to suppress the warnings. Unlike C++ CodeQL suppressions, we don't have an opaque ID with a specific suppression syntax to follow, but prefixing the comment with "CodeQL:" will be a good reminder that these comments serve a purpose.
For the line: ```py cmd, out, err, rc = self.runStep(step, litConfig) ``` this is complaining: "Assigning multiple variables without ensuring that you define a value for each variable causes an exception at runtime." I speculate that this is happening because CodeQL doesn't understand what we're doing with the 3-tuple returned by executeCommand(). I'm hoping that explicitly unpacking it into 3 variables, before composing runStep()'s 4-tuple result, will make it happy.
cpplearner
reviewed
Apr 7, 2026
BillyONeal
approved these changes
Apr 10, 2026
davidmrdavid
approved these changes
Apr 13, 2026
Member
Author
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if VALUE in LIST.cmd, out, err, rc = self.runStep(step, litConfig)this is complaining: "Assigning multiple variables without ensuring that you define a value for each variable causes an exception at runtime." I speculate that this is happening because CodeQL doesn't understand what we're doing with the 3-tuple returned by executeCommand(). I'm hoping that explicitly unpacking it into 3 variables, before composing runStep()'s 4-tuple result, will make it happy.