<memory>: add _EXPORT_STD for start_lifetime_as and start_lifetime_as_array#6254
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Apr 17, 2026
Merged
<memory>: add _EXPORT_STD for start_lifetime_as and start_lifetime_as_array#6254StephanTLavavej merged 1 commit intomicrosoft:mainfrom
<memory>: add _EXPORT_STD for start_lifetime_as and start_lifetime_as_array#6254StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
StephanTLavavej
approved these changes
Apr 15, 2026
Member
<memory>: add _EXPORT_STD marco for start_lifetime_as and start_lifetime_as_array<memory>: add _EXPORT_STD for start_lifetime_as and start_lifetime_as_array
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Member
|
Thanks again for fixing my bug and congratulations on your first microsoft/STL commit! 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if
_EXPORT_STDis intentionally removed fromstart_lifetime_asandstart_lifetime_as_arraybecause withoutexportmsvc still successfully compiled code usingimport std;withstart_lifetime_asandstart_lifetime_as_array.Anyway Resharper detected that they are not exported and leave red color on them, so I did this.