Add lib types for JSON.rawJSON, JSON.isRawJSON, and reviver context#63248
Open
VedantMadane wants to merge 2 commits intomicrosoft:mainfrom
Open
Add lib types for JSON.rawJSON, JSON.isRawJSON, and reviver context#63248VedantMadane wants to merge 2 commits intomicrosoft:mainfrom
VedantMadane wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Adds esnext.json.d.ts with type definitions for the Stage 4 TC39
proposal-json-parse-with-source (shipped in all major browsers and
Node.js 22+):
- JSON.rawJSON(text): creates a RawJSON object for lossless serialization
- JSON.isRawJSON(value): type guard narrowing to RawJSON
- JSON.parse reviver context: third parameter with { source: string }
Fixes microsoft#61330
The proposal-json-parse-with-source is Stage 4 and part of ES2025, so the lib should live in es2025.json.d.ts, not esnext.json.d.ts.
Contributor
It isn't, MDN is wrong on this one. It has stage 4 approval, but is not yet in the latest draft: tc39/ecma262#3714 |
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
Member
|
Reopening as this is still valid (minus commandlineParser.ts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
es2025.json.d.tswith type definitions for the Stage 4 TC39 proposal-json-parse-with-source which is part of ES2025 and has shipped in all major browsers and Node.js 22+.Summary
JSON.rawJSON(text)- creates a frozenRawJSONobject for lossless JSON serialization (e.g. preserving large-integer precision)JSON.isRawJSON(value)- type-guard that narrows toRawJSONJSON.parserevivercontext- overload whose reviver receives a third parameter{ source: string }containing the original JSON source text of each primitive valueNew files
src/lib/es2025.json.d.tsRawJSONinterface +JSONaugmentationstests/cases/compiler/jsonParseWithSource.tstests/baselines/reference/jsonParseWithSource.*Modified files
src/lib/es2025.d.ts/// <reference lib="es2025.json" />src/lib/libs.jsones2025.jsonsrc/compiler/commandLineParser.tses2025.jsonto its.d.tsFixes #61330