fix: remove extra arg from dry-run logger.info call#2326
Open
ABD07xx wants to merge 3 commits intomicrosoft:mainfrom
Open
fix: remove extra arg from dry-run logger.info call#2326ABD07xx wants to merge 3 commits intomicrosoft:mainfrom
ABD07xx wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Fixes microsoft#2254 — logger.info() was called with an extra True positional argument and no matching %s placeholder, causing TypeError with some logging backends (e.g. Ollama).
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove extra positional argument from
logger.info()in the dry-run exit path.The format string has no
%splaceholder, so passingTrueas a second argument can cause:This occurs with certain logging backends that strictly validate format arguments.
Related Issues
Fixes #2254
Proposed Changes
packages/graphrag/graphrag/cli/index.pyBefore
After
Checklist
Additional Notes
The extra
Trueargument is a no-op in most logging backends, but raises aTypeErrorin backends that strictly validate format arguments (reproducible with Ollama-based setups).This is a minimal (1-character) fix with no impact on the normal execution path.