Add argument "all" to "rep" command and new "emblems" command#2035
Add argument "all" to "rep" command and new "emblems" command#2035Wishmaster117 wants to merge 25 commits intomod-playerbots:test-stagingfrom
Conversation
b98a2ca to
b9fe0c3
Compare
|
Multibot ready: 
|
…blems-command_rebased
…blems-command_rebased
…blems-command_rebased
|
Ready to merge :D |
Celandriel
left a comment
There was a problem hiding this comment.
Still wrapping my head around the rest. but these two should fix.
BTW I don't modified conf/playerbots.conf.dist it's added in the pr don't know how I don't modified src/Bot/RandomPlayerbotMgr.cpp also added by i don't know what Same thing with PULL_REQUEST_TEMPLATE.md don't know how it has been added to the pr |
Add a newline at the end of TellEmblemsAction.cpp
Fix missing newline at end of TellEmblemsAction.cpp
Master update from Test-staging: Fix ObjectAccessor retrieval, optimize EquipActions, and implement RaidBossHelpers
|
@kadeshar , @Celandriel , @hermensbas , Is there an issue with this PR that’s preventing it from being merged? |
This reverts commit c86032f.
Master update from Test staging
| #include <array> | ||
| #include <algorithm> | ||
| #include <utility> | ||
| #include <vector> |
There was a problem hiding this comment.
I havent double checked it, but clang tells me that only algorithm is needed from these first 4 includes.
| bool TellReputationAction::Execute(Event /*event*/) | ||
| #include "SharedDefines.h" | ||
|
|
||
| namespace |
There was a problem hiding this comment.
I generally have an issue with a namespace functions and feel like this is better suited as a member unless its specifically being called by other classes that would not be inheriting from this class.
Update master from Test staging and Core Update
Test staging to master
Test staging to master
…blems-command_rebased
Summary
reputation allto a curated list of WotLK/BC/Classic faction IDs (filtered by team)emblemschat command to report emblem countsMultibot will need a update