Skip to content

Remove fire totem override from enhancement AOE strategy#2270

Draft
dillyns wants to merge 2 commits intomod-playerbots:test-stagingfrom
dillyns:enhanceShamanAoeFireTotemFix
Draft

Remove fire totem override from enhancement AOE strategy#2270
dillyns wants to merge 2 commits intomod-playerbots:test-stagingfrom
dillyns:enhanceShamanAoeFireTotemFix

Conversation

@dillyns
Copy link
Copy Markdown
Contributor

@dillyns dillyns commented Mar 31, 2026

Pull Request Description

Currently in AOE enchancement shamans are dropping magma totems. They should not be overriding the set fire totem strategy.

Feature Evaluation

  • Describe the minimum logic required to achieve the intended behavior.
  • Describe the processing cost when this logic executes across many bots.

How to Test the Changes

Bring an enhancement shaman into medium aoe scenario (3 enemies)
They should no longer replace their fire totem with magma totem. They should only drop the fire totem that is set in their strategies.

Impact Assessment

  • Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?

      • No, not at all
      • Minimal impact (explain below)
      • Moderate impact (explain below)
  • Does this change modify default bot behavior?

      • No
      • Yes (explain why)
  • Does this change add new decision branches or increase maintenance complexity?

      • No
      • Yes (explain below)

Messages to Translate

  • Does this change add bot messages to translate?
      • No
      • Yes (list messages in the table)
Message key Default message

AI Assistance

  • Was AI assistance used while working on this change?
      • No
      • Yes (explain below)

Final Checklist

    • Stability is not compromised.
    • Performance impact is understood, tested, and acceptable.
    • Added logic complexity is justified and explained.
    • Documentation updated if needed (Conf comments, WiKi commands).

Notes for Reviewers

@kadeshar
Copy link
Copy Markdown
Collaborator

kadeshar commented Apr 1, 2026

Currently there is totem strategy which automatic switch between Totem of Wrath/Searing Totem (depends of Demonic Pact) in single target fight to Magma Totem in AOE fight and back?

@kadeshar
Copy link
Copy Markdown
Collaborator

kadeshar commented Apr 6, 2026

Conflict

@kadeshar kadeshar marked this pull request as draft April 17, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants