Remove fire totem override from enhancement AOE strategy#2270
Draft
dillyns wants to merge 2 commits intomod-playerbots:test-stagingfrom
Draft
Remove fire totem override from enhancement AOE strategy#2270dillyns wants to merge 2 commits intomod-playerbots:test-stagingfrom
dillyns wants to merge 2 commits intomod-playerbots:test-stagingfrom
Conversation
Collaborator
|
Currently there is totem strategy which automatic switch between Totem of Wrath/Searing Totem (depends of Demonic Pact) in single target fight to Magma Totem in AOE fight and back? |
Collaborator
|
Conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Currently in AOE enchancement shamans are dropping magma totems. They should not be overriding the set fire totem strategy.
Feature Evaluation
How to Test the Changes
Bring an enhancement shaman into medium aoe scenario (3 enemies)
They should no longer replace their fire totem with magma totem. They should only drop the fire totem that is set in their strategies.
Impact Assessment
Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?
Does this change modify default bot behavior?
Does this change add new decision branches or increase maintenance complexity?
Messages to Translate
AI Assistance
Final Checklist
Notes for Reviewers