Skip to content

Exclude Isle of Quel'danas Areas From PvP#2304

Merged
Celandriel merged 13 commits intomod-playerbots:test-stagingfrom
brighton-chi:add-ioq-pvp-prohibited-areas
Apr 17, 2026
Merged

Exclude Isle of Quel'danas Areas From PvP#2304
Celandriel merged 13 commits intomod-playerbots:test-stagingfrom
brighton-chi:add-ioq-pvp-prohibited-areas

Conversation

@brighton-chi
Copy link
Copy Markdown
Contributor

Pull Request Description

Adds the vendor/quest hub areas of the Isle of Quel'danas to excluded PvP areas (Shattered Sun Staging Area, Sun's Reach Sanctum, Sun's Reach Harbor, Sun's Reach Armory). Otherwise, bots attack each other and piss off all the Shattered Sun Offensive guards and NPCs.

Feature Evaluation

  • Describe the minimum logic required to achieve the intended behavior.
  • Describe the processing cost when this logic executes across many bots.

How to Test the Changes

Go to one of the above-mentioned areas while PvP flagged (or on a PvP server, like me). See if bots attack.

Impact Assessment

  • Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?

      • No, not at all
      • Minimal impact (explain below)
      • Moderate impact (explain below)
  • Does this change modify default bot behavior?

      • No
      • Yes (explain why)
  • Does this change add new decision branches or increase maintenance complexity?

      • No
      • Yes (explain below)

AI Assistance

Was AI assistance used while working on this change?

    • No
    • Yes (explain below)

Final Checklist

    • Stability is not compromised.
    • Performance impact is understood, tested, and acceptable.
    • Added logic complexity is justified and explained.
    • Any new bot dialogue lines are translated.
    • Documentation updated if needed (Conf comments, WiKi commands).

Notes for Reviewers

@brighton-chi brighton-chi changed the title Exclude Isle of Quel'danas Areas to PvP Exclude Isle of Quel'danas Areas From PvP Apr 11, 2026
@Celandriel Celandriel merged commit d01316f into mod-playerbots:test-staging Apr 17, 2026
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants