Make ByteBuddy handler instance-scoped to prevent leaks#773
Merged
chhsiao90 merged 1 commit intomodelmapper:masterfrom Sep 30, 2025
Merged
Make ByteBuddy handler instance-scoped to prevent leaks#773chhsiao90 merged 1 commit intomodelmapper:masterfrom
chhsiao90 merged 1 commit intomodelmapper:masterfrom
Conversation
…tionHandler for ByteBuddy proxies
Member
|
Thanks, LGTM |
Member
|
Just released 3.2.5, it should be available soon from the maven central. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move from class-scoped to instance-scoped InvocationHandler in generated proxies:
This prevents the proxy class from holding a class-level reference to the handler, which previously retained ExplicitMappingBuilder and InheritingConfiguration captured by the handler.
In issue #375-like scenarios, this reduces retained heap and avoids long-lived retention without changing behavior.