Skip to content

Kotlin extension with data class support#781

Closed
kendarorg wants to merge 14 commits intomodelmapper:masterfrom
kendarorg:kotlin-extension
Closed

Kotlin extension with data class support#781
kendarorg wants to merge 14 commits intomodelmapper:masterfrom
kendarorg:kotlin-extension

Conversation

@kendarorg
Copy link
Copy Markdown
Contributor

  • Support for data class
  • Support for custom "not default constructor" personalization

@chhsiao90
Copy link
Copy Markdown
Member

Thanks for the PR, this is a really big PR, is it possible to remove some unnecessary change and minimize the PR (like coding style change) so I can review it?

@kendarorg
Copy link
Copy Markdown
Contributor Author

kendarorg commented Nov 3, 2025

  • Removed useless classes
  • Removed "forgotten" comments
  • Added javadoc generation for maven publish
  • Added default "do nothing" ConstructorInjector
  • Uniform approach to mutators
  • Reformat complying to original formatting
  • Support for inheritable configuration

PS No AI has been used for this PR! :)

@kendarorg
Copy link
Copy Markdown
Contributor Author

kendarorg commented Nov 4, 2025

And tell me everything is wrong, no mercy, i tried to stick to the approach of the rest of code but i can change everything:)

@chhsiao90
Copy link
Copy Markdown
Member

I'm working on this and will keep you posted about the updates.

@chhsiao90
Copy link
Copy Markdown
Member

It should be supported by 14145e1 and was released as ModelMapper 3.2.6

BTW, I'm not going to include the Kotlin as part of core ModelMapper for many reasons. I'd like to include it as a 3rd party module (see https://github.com/modelmapper/modelmapper/blob/master/README.md#modules).

@chhsiao90 chhsiao90 closed this Nov 11, 2025
@kendarorg
Copy link
Copy Markdown
Contributor Author

kendarorg commented Nov 11, 2025

BTW, I'm not going to include the Kotlin as part of core ModelMapper for many reasons.

I was not that sure too, imho it involves lots of dependencies that does not fit much with all the rest, btw you are the maintainer and i discovered this project 2 weeks ago ;) i am super happy for all this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants