Show file upload progress and placeholder media message in chat.#6047
Open
anakin78z wants to merge 1 commit intonextcloud:masterfrom
Open
Show file upload progress and placeholder media message in chat.#6047anakin78z wants to merge 1 commit intonextcloud:masterfrom
anakin78z wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Jens Zalzala <[email protected]>
7978ebe to
8261f43
Compare
Collaborator
|
Glad to see works that build on to of the recent changes (yes it makes sense to start with a fresh approach instead the old approach for chatkit). Please let us know if there are any questions or it is ready to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2375
I'm aware of the work in progress at #5317 but I couldn't get it to work when I tried it, and since there were a lot of changes with the ChatKit removal, I thought it best to start fresh.
🖼️ Screen captures:
The X button in the top right cancels the upload.
Uploading images are blurred to indicate they are not yet fully sent (they remain blurred until the device receives the chat message from the server). The idea is to make it obvious that the messages can't be interacted with as a regular media message.
Video demo:
https://youtube.com/shorts/FMw_yvhxXL4
🚧 ISSUES
I created issue #6081 for the following:
After a file has uploaded, but before the insurance request is made, tapping the image/video fails. While investigating this, I noticed that the return values from the WebSocket and the insurance request are different:
The link and path parameters both have different values. I'm not sure if this is a server issue, or if the responses need to be handled differently, but it's odd that the link would be different.
My server version is 33.0.0
🏁 Checklist
/backport to stable-xx.x