Conversation
Owner
nhtgl
commented
Feb 4, 2025
- Implement pipenv language module in pre-commit
- Update workflows to include pipenv language tests
- Add pipenv language to allowed languages in testing script
- Create comprehensive test suite for pipenv language support
- Implement pipenv language module in pre-commit - Update workflows to include pipenv language tests - Add pipenv language to allowed languages in testing script - Create comprehensive test suite for pipenv language support
- Add explicit virtualenv creation and environment settings for pipenv - Implement more robust health check and installation processes - Modify run_hook to use pipenv run with proper environment configuration - Update tests to verify new pipenv language behavior
- Simplify and streamline pipenv language tests - Enhance test coverage and readability - Remove unnecessary imports and code complexity - Update test fixtures and mocking strategies
- Modify test to pass script path as a single argument in pipenv run command - Ensure compatibility with pipenv command execution in test environment
- Add tests for health check failure scenarios - Implement tests for environment installation with and without additional dependencies - Expand run_hook tests to cover file argument passing - Improve test coverage for pipenv language module
…rror handling - Add `_find_pipfile()` to search for Pipfile in current and parent directories - Modify `_assert_pipfile_exists()` to return Pipfile directory - Update methods to use the nearest Pipfile directory for pipenv commands - Improve error handling in health check and environment setup - Add comprehensive tests for Pipfile discovery and error scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.