Conversation
VisualMelon
left a comment
There was a problem hiding this comment.
Thanks for looking into this. I'm hoping to find the time and energy soon to deal with this sort of thing, so feel free to @ me directly if I'm slow to respond, but it's going to take time for me to review everything and work out how nuget works again etc. etc.
| <PropertyGroup> | ||
| <TargetFrameworks>net462;net6.0;net8.0</TargetFrameworks> | ||
| <TargetFrameworks>net462;net8.0;net10.0</TargetFrameworks> | ||
| <AllowMissingPrunePackageData>true</AllowMissingPrunePackageData> |
There was a problem hiding this comment.
Do we know what this is about?
There was a problem hiding this comment.
AllowMissingPrunePackageData suppresses errors when NuGet's package pruning data is unavailable for one or more target frameworks.
Since .NET 9, NuGet introduced package pruning (trims transitive package dependencies based on a framework's built-in packages list). When a target framework (net462 and net6.0) don't have that pruning data available, the restore process would fail. Setting this to true so NuGet just skip pruning for those frameworks.
There was a problem hiding this comment.
We can remove this line when net462 goes out of support in January 2027, so after that maybe february or something, we can remove net462 and remove that line
|
@VisualMelon I went through your comments, posted responses and made the necessary changes |
|
@VisualMelon any new comments to this? |
|
@VisualMelon how likely is it this will be merged in and we can have a new release of oxyplot.skiasharp before mid-may? All the best, |
Fixes # .
The goal was to upgrade some nuget packages in Oxyplot.Skiasharp that had some problems.
#2160
And packages with vulnerabilities
For that purpose:
Hoping it can be used for a needed new release of Oxyplot.Skiasharp nuget
Checklist
Changes proposed in this pull request:
@oxyplot/admins