respect aliases SKIP when installing environments#2479
Closed
kmARC wants to merge 1 commit intopre-commit:mainfrom
Closed
respect aliases SKIP when installing environments#2479kmARC wants to merge 1 commit intopre-commit:mainfrom
kmARC wants to merge 1 commit intopre-commit:mainfrom
Conversation
asottile
reviewed
Aug 10, 2022
Member
asottile
left a comment
There was a problem hiding this comment.
just future open source advice, don't make PRs from your main branch as it makes it significantly more difficult to review / fix
Comment on lines
644
to
+650
|
|
||
| ret, printed = _do_run( | ||
| cap_out, store, repo_with_passing_hook, | ||
| run_opts(all_files=True), | ||
| {'SKIP': 'skipme-1'}, | ||
| ) | ||
| assert ret == 1 |
Member
There was a problem hiding this comment.
this test now validates two separate things -- it should be two separate tests
Contributor
Author
There was a problem hiding this comment.
just future open source advice, don't make PRs from your
mainbranch as it makes it significantly more difficult to review / fix
Sure. I was in the gerrit workflow mindset.
I can put it in a separate test method.
I see the CI failing, should I rebase on v2.20.0 or is this fine?
Contributor
Author
|
I am closing this PR and will open one from our company GH account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2478