Conversation
|
I think the descriptions should override each other instead, makes more sense to see the python specific description when the python version of run_unit_tests is used? This would mean always using the "last one". |
i understand but why do we need a "default" |
Yes you're right, but IMHO the override solution "just works" in all cases. |
to make it clear, this change has no influence on third-party plugins or optional plugins e.g pybuilder sphinx plugin. it's just for there is no extra benefit for plugin developers if we overwrite the descriptions in IMHO, but maybe i don't get it , pls help me to understand it |
|
Well I think there is, a plugin that provides a run_unit_tests task is completely valid. With overwrites I would get the generic unit test task description without having to do anything. If my plugin just runs unit tests then I shouldn't have to duplicate the "upstream" description. The advantage is that generic tasks have "sane default" descriptions that can still be overridden. |
|
Also it totally affects other plugins, if I have a plugin with a task called I like the idea that we can refine task descriptions progressively:
and so on |
|
In general it sounds like a very good idea, but i think this is a new feature. Maybe we can sum it up in a new ticket. What do you think? I just want to get rid of the dublicates but i understand that we need the override mechanism. btw. if no description is provided you will get a placeholder |
fixing #142