VBA - retain unlabeled axis plotting behavior#306
VBA - retain unlabeled axis plotting behavior#306jGaboardi wants to merge 1 commit intopysal:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=====================================
Coverage 90.2% 90.2%
=====================================
Files 11 11
Lines 1308 1311 +3
=====================================
+ Hits 1180 1183 +3
Misses 128 128
🚀 New features to boost your workflow:
|
martinfleis
left a comment
There was a problem hiding this comment.
My general suggestion here is to wait.
| legend=False, | ||
| legend_kwargs=None, | ||
| min_alpha=0.2, | ||
| axis_labels=False, |
There was a problem hiding this comment.
Can we wait until this is resolved in geopandas? If we're adding a keyword there, we will want it to be the same here.
There was a problem hiding this comment.
Yes, absolutely. I will convert to draft. I was under the impression that there would probably not be a keyword added upstream.
| Minimum alpha threshold to prevent fully transparent masking. | ||
| axis_labels : bool = False | ||
| Remove CRS unit axis labels from the returned ``ax``. This retains default | ||
| behavior in ``mapclassify`` and only has an affect when ``geopandas>v1.1.3`` |
There was a problem hiding this comment.
| behavior in ``mapclassify`` and only has an affect when ``geopandas>v1.1.3`` | |
| behavior in ``mapclassify`` and only has an affect when ``geopandas>=v1.2`` |
There might be 1.1.4 which will not contain new plotting.
| if not axis_labels: | ||
| ax.set_xlabel("") | ||
| ax.set_ylabel("") |
There was a problem hiding this comment.
Again, if this is going to be solved on geopandas side, we would just want to pass the keyword.
This PR
vba_choropleth()#305dev#295 (comment)geopandas@mainbeing installed is coming in tagged as1.1.2.dev90+g587cc34faso the label-specific test is being skipped until the next release of geopandas.