Skip to content

Change from Mustache to Handlebars for string template methods #28 6h#36

Open
jamespaulengay wants to merge 2 commits intostackpress:mainfrom
jamespaulengay:feat/28
Open

Change from Mustache to Handlebars for string template methods #28 6h#36
jamespaulengay wants to merge 2 commits intostackpress:mainfrom
jamespaulengay:feat/28

Conversation

@jamespaulengay
Copy link
Copy Markdown
Collaborator

@jamespaulengay jamespaulengay commented Apr 6, 2026 •
edited
Loading

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue Change from Mustache to Handlebars for string template methods #28
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

@jamespaulengay
Copy link
Copy Markdown
Collaborator Author

jamespaulengay commented Apr 6, 2026 •
edited
Loading

field.relation using clip title 15

Screenshot 2026-04-07 at 1 51 50 AM

display

lowercase
Screenshot 2026-04-07 at 1 44 56 AM

uppercase + clip
Screenshot 2026-04-07 at 1 47 03 AM

view.template using either
Screenshot 2026-04-07 at 1 38 27 AM
Screenshot 2026-04-07 at 1 39 05 AM

list.template using either
Screenshot 2026-04-07 at 1 35 35 AM
Screenshot 2026-04-07 at 1 37 20 AM

@jamespaulengay
Copy link
Copy Markdown
Collaborator Author

jamespaulengay commented Apr 6, 2026

@display using formula helper
Screenshot 2026-04-07 at 2 20 35 AM

cblanquera
cblanquera requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage of variable html might be confusing because other developers will think it's okay to use HTML, when react will escape it. Recommended to change html to template as in: const template = Handlebars.compile('<%template%>'); which is more accurate that handlebars returns a template function.

Comment thread stackpress/package.json
Copy link
Copy Markdown
Member

@cblanquera cblanquera Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mustache should be removed from dependency list.

Copy link
Copy Markdown
Member

@cblanquera cblanquera Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mustache is still there.

Image

Copy link
Copy Markdown
Collaborator Author

@jamespaulengay jamespaulengay Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I'm still working on this part.

Comment thread stackpress/src/view/handlebars.ts
Comment thread stackpress/src/view/transform/view/template.ts
Comment thread stackpress/src/view/transform/list/template.ts
Comment thread stackpress/src/view/transform/form/relation.ts
Comment thread stackpress/src/view/transform/filter/relation.ts
@jamespaulengay
Refactor Handlebars variable naming for consistency across detail, cr…
846c3dd 
…eate, search, remove, restore, update, relation, and template views stackpress#28 1m
cblanquera
cblanquera requested changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove mustache from dependency list and retest to make sure it's no longer being used.

Comment thread stackpress/package.json
Copy link
Copy Markdown
Member

@cblanquera cblanquera Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mustache is still there.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblanquera cblanquera cblanquera requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamespaulengay @cblanquera