add random_state to svd_interface()#616
Conversation
|
Having had a look around some more, there are a few more instances of svd_interface() that require passing random_state |
aarmey
left a comment
There was a problem hiding this comment.
Thanks @MrBones1102! Could you please fix those other uses of svd_interface()? They should pass on random_state for the same reason as here.
If a function calls svd_interface(), but does not have a random state, note it and I can take a look.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 88.07% 88.13% +0.05%
==========================================
Files 132 132
Lines 7943 7941 -2
==========================================
+ Hits 6996 6999 +3
+ Misses 947 942 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Added all other instances where As a result, the following enclosing functions were modified to take
Additionally, I modified the |
|
Take a look at the test errors here. I'm happy to discuss them if it's not clear what broke. |
From #615. Pass
rngto newrandom_stateinsvd_interface()for use as kwargs in subsequent randomized svd initialization