Skip to content

feat(textAngularSetup): Added superscript support#1278

Open
dudyn5ky1 wants to merge 1 commit intotextAngular:masterfrom
dudyn5ky1:add-superscript-support
Open

feat(textAngularSetup): Added superscript support#1278
dudyn5ky1 wants to merge 1 commit intotextAngular:masterfrom
dudyn5ky1:add-superscript-support

Conversation

@dudyn5ky1
Copy link
Copy Markdown

Added superscript tag support (<sup>).

@JoelParke
Copy link
Copy Markdown
Collaborator

We should also have subscript and be able to toggle between them somehow - not sure on the UI side. Also, I don't know if the browsers detect this in queryCommandState('superscript');
Firefox seems to, but Chrome doesn't. Any thoughts...
Thanks,
Joel

@dudyn5ky1
Copy link
Copy Markdown
Author

dudyn5ky1 commented Aug 24, 2016

@JoelParke I've already implemented subscript in my fork, just waiting for you to approve this PR.

Yes, webkit browsers doesn't detect queryCommandState('superscript'), as well as queryCommandState('subscript') so on Chrome/Safari we are not able to 'unset' selection, only by using 'clear' option, or toggle between between sub/sup.

I see here 2 options:

  1. Create custom workaround for superscript & subscript;
  2. Leave it as it is, because <sup> and <sub> support is quite an important issue;

What do you think?
Thx,
Maksym

@JoelParke
Copy link
Copy Markdown
Collaborator

I will be away for a couple of weeks and then when I get back, I will think about this, but I need to resolve the issues around firefox/chrome differences first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants